Philip Zembrod
Philip Zembrod
Fixed with commit https://github.com/pzembrod/VolksForth/commit/3a4eff97c41884d9232b2ee5bee899b42efc66e1 - will need to be bundled into a release and merged into the main repo and branch yet, though.
Fixed in C64-390 branch
Clarification: fixed in the C64/C16 code, nowhere else yet
> @pzembrod The best way to test this would be a starlark analysis test, but those aren't open-source yet. Could you maybe add one to the internal test suite? Sorry,...
> @pzembrod The best way to test this would be a starlark analysis test, but those aren't open-source yet. Could you maybe add one to the internal test suite? Hi...
As discussed on Slack, let's merge this now, and I'll open a tracking bug for me so we can see next quarter how to best test this.
I'll close this as a duplicate of two issues, #24990 (Add custom additional_outputs to cc_common.link) and #22036 (Add additional_outputs parameter to cc_common.compile).
I think shortening cc_shared_library/test_cc_shared_libraryX to cc_shared_library/testX is a good idea, not just okay. I think the context for the tests is absolutely clear enough from the parent directory cc_shared_library so...
> @pzembrod Could you roll back this change? I still haven't found a good solution to #24518 and I don't think I will have the capacity to investigate this further....
@fmeum Thanks for taking a look. The rollback is now submitted.