Linas Valiukas comments

Results 53 comments of


                                            Linas Valiukas

[RFR] Print test failures in GH Actions

I think GHA doesn't run step *n+1* if step *n* has failed, so you might want to either make the "Run tests" step exit with a zero error code, merge...

[RFR] Print test failures in GH Actions

Merged in `master` to trigger a rebuild (the old one has expired).

[RFR] Print test failures in GH Actions

So printing failures as GitHub Actions annotations didn't work?

Account Activation Failed

Hm, weird. Works for me, just tried it (on tools.mediacloud.org). Could you forward me the activation email to [email protected]?

fix jieba cache issue

Doesn't seem to build :(

fix jieba cache issue

Could be missing `apt update`, halfway fixed in f0c523e

fix jieba cache issue

It's the same issue as #775

slow solr imports

I think this is because they have been OOMing constantly as 100k stories (the default chunk size) is quite a bit to load into RAM at once. I've increased the...

replace 're' module with 'regex' module

Matching words with `\w` wouldn't work in all the cases anyways, and will lead us to using various nasty hacks, e.g. `is_logogram`. This has became even more important now that...

sort stories by publish date desc via API not working

That wouldn't be a particularly hard change, a day of work with tests I suppose. How important / urgent is it in relation to other things currently on my plate...