Philipp Albrecht

Results 79 comments of Philipp Albrecht

> QMK already picked up these changes in the `develop` branch, so testing is even easier. Just switch/rebase/pull to this branch and update the submodules `qmk git-submodule` and a fresh...

Here you go: #8203 Feedback is very much appreciated!

@toofar, could you ellaborate a bit on (https://github.com/qutebrowser/qutebrowser/issues/7407#issuecomment-1257085679): > add a decorator so the individual items can be dynamically registered instead of having a list of them maintained in the...

Fixed in https://github.com/servo/servo/pull/32643.

First of all thank you so much for your elaborate feedback. Very valuable! I will address it in a chronological order; easier for my post-workday brain. --- @The-Compiler > I'm...

I finally got around to look into this again and only now did I properly understand @The-Compiler's proposal in https://github.com/qutebrowser/qutebrowser/issues/7407#issue-1382023382: > Make widgets StatusbarItem subclasses, and have the widget as...

@The-Compiler, following your approach > Make widgets StatusbarItem subclasses, and have the widget as .widget instead of inheriting from it directly - somewhat similar to what we did for TabbedBrowser...

@toofar, thanks for your feedback! FYI: I opened #8240 to play with the composition approach.