Philipp Albrecht
Philipp Albrecht
This is based on https://github.com/servo/servo/tree/named-getter. I opened this PR to keep track of changes and related discussions (..and run CI at some point).
The build currently fails (which I kind of expected for a WIP): ``` error[E0609]: no field `name_map` on type `&dom::window::Window` --> components/script/dom/window.rs:1483:29 | 1483 | let name_map = self.name_map.borrow(); |...
I implemented getters for `id_map` and `name_map` to see if the build succeeds, but that got me into scary territory: ``` error[E0133]: use of extern static is unsafe and requires...
That did it, thanks! Are there any related tests I can run? @jdm, or can you trigger a CI build to see what tests pass/fail? // edit: Nevermind, I think...
So, I started to work on this TODO: ```rust // TODO: Handle the document-tree child browsing context name property set. ``` The [spec for named-access-on-the-window-object](https://html.spec.whatwg.org/multipage/window-object.html#named-access-on-the-window-object) states: > 1. If window's...
> The document-tree child browsing context name property set isn't what you return to the caller, so you aren't wrapping it into a JSObject. The spec's invoking the concept of...
> Let childBrowsingContexts be all document-tree child browsing contexts of window's browsing context I know how to get the window's browsing context (`document.browsing_context()`), but I am not sure how to...
Now I'm confused, but that's probably due to a lot of missing domain knowledge. So my apologies if the following statements/questions make absolutely no sense. I'm just trying to make...
Thank you very much for elaborating! Now I have a good idea of how to approach this. And it turned out much simpler than I imagined it to be in...
Alright, so I feel I know what to do on an abstract level, but mapping it to code is quite a challenge for me. So far I found two things...