Philipp Albrecht

Results 74 comments of Philipp Albrecht

As this turned out to be a little over my head, I will unassign myself and leave it up to the experts to solve this.

I am having the same issues when opening reddit URLs. Once I get a free minute I will drop my details in a comment and start debugging.

@toofar, thanks for your thorough review! ..and apologies for letting it just sit there for the past couple of days. I will work on your suggestions in the next days.

@toofar, I updated the `:tab-focus parent` test. That one is now failing: ``` FAILED tests/end2end/features/test_treetabs_bdd.py::test_tabfocus_parent - AssertionError: assert ' http://localhost:64851/data/numbers/2.txt' == ' http://localhost:64851/data/numbers/3.txt' ``` After inspecting the session, it seems...

> _gasp_ how dare you! My code is always perfect! Forgive me, master. Never shall I place your code in doubt again. 🙏 > What I find useful as the...

> the tab-next and tab-prev tests have the same setup and assertion. If I can swap one command out for the other, how do I know that the two commands...

Now the `:tab-prev --sibling` test is failing for some reason. I will look into it tomorrow.

Debugging was easier than expected. > I think the problem here is that since tab 3 is already focused tab-focus 3 ends up [switching away](https://github.com/qutebrowser/qutebrowser/blob/main/qutebrowser/browser/commands.py#L1033) from the active tab to...

I played around with `:tab-move`. `:tab-move start` and `:tab-move ` were pretty intuitive. However using the special arguments (`+`, `-`, `end`) tripped me up quite a bit. I still haven't...

@toofar, whenever you get a chance, this is ready to be reviewed. As usual your feedback is very much appreciated and valued! Even though I wanted to add more tests,...