Philipp Albrecht

Results 74 comments of Philipp Albrecht

My apologies for my progress being slower than promised in my last comment. I got a little carried away hacking on some wargames. This PR is still on my radar,...

So far a basic implementation for checking the following calls for the existence of the `spec` or `autospec` argument is in place: - `patch()` - `patch.object()` - `patch.multiple()` - `Mock()`...

I got a little distracted by my unpredictable kids and returning back to work after being on parental leave, but I finally got some time to work on this. I...

Oh wow, I force pushed an outdated fork from my other machine without knowing it was outdated the whole time.. I pushed my latest changes now, let's see if CI...

..and the tests are failing. I could've sworn I left this PR in a green state. Parental sleep deprivation seems to be getting to me. I will take care of...

> possibly due to recent changes in the pylint testing helpers Thanks for the hint. This was indeed the cause for the failing tests.

Alright, I cleaned up the commit history. So I would consider this now ready for review. Please take your time!

That's probably, because I did not add a commit for integrating the checkers in `run_pylint_on_tests.py`. [This now looks like what you would expect](https://github.com/qutebrowser/qutebrowser/runs/5810639489?check_suite_focus=true#step:8).

I fixed the `patch()` calls by adding `autospec=True` and was already presented with some test failures.

Thanks for your feedback and for pointing out that bug. I totally missed the case that someone can pass in an object with `new`. Unfortunately I was super swamped with...