Aditya Keerthi

Results 20 comments of Aditya Keerthi

Should we also change the serialization of `mask-size` to always use two values, for consistency?

There are two WPTs that current assume single-value serialization: ``` css/css-animations/KeyframeEffect-getKeyframes.tentative.html quirks/unitless-length/excluded-properties-002.html ``` I would like to update these tests as part of the WebKit change. @zcorpan @karlcow Do we...

Following the change to gCS, the following WPTs are failing: ``` imported/w3c/web-platform-tests/css/css-backgrounds/background-332.html imported/w3c/web-platform-tests/css/css-backgrounds/background-size-001.html imported/w3c/web-platform-tests/css/css-backgrounds/parsing/background-size-computed.html imported/w3c/web-platform-tests/css/cssom/getComputedStyle-pseudo.html ``` They expect a single value for `background-size`, when a single value is specified. If...

> iOS needs a similar rebaseline for LayoutTests/imported/w3c/web-platform-tests/css/cssom/getComputedStyle-pseudo.html Not sure what's going on here – the patch contains a baseline in `LayoutTests/platform/ios/imported/w3c/web-platform-tests/css/cssom/getComputedStyle-pseudo-expected.txt`, and the test is passing locally 🤔

(turns out there's already a baseline in `ios-wk2`, will update that one instead of adding a new one)

> It’s not clear to me whether our goal for named colors should be to fit in really well with the surrounding operating system, or rather to just choose values...

Should we rename the bug/PR title to "Fix \ box-sizing in UA stylesheet"? It doesn't look like this is actually about about `` elements, and `box-sizing` is not an inherited...

The commit message is missing the `Reviewed by NOBODY (OOPS!).` line.

It looks like the PR description is incorrectly formatted, did you use `git webkit pr`? Instructions can be found [here](https://github.com/WebKit/WebKit/wiki/Pull-Requests).

> > It looks like the PR description is incorrectly formatted, did you use `git webkit pr`? Instructions can be found [here](https://github.com/WebKit/WebKit/wiki/Pull-Requests). > > I tried to use this tool,...