Adds "box-sizing: border-box" to table in UA stylesheet

[karlcow]

699e270b239fd047f8f756e334a5703aea25e4f8

Adds "box-sizing: border-box" to table in UA stylesheet
https://bugs.webkit.org/show_bug.cgi?id=243234
<rdar://97634949>

Reviewed by NOBODY (OOPS!).

This changes the UA stylesheet to match to the spec
and adjusts the relevant tests.
https://html.spec.whatwg.org/#tables-2

* Source/WebCore/css/html.css:
(table):
* LayoutTests/fast/borders/border-image-fill-no-border-expected.html:
* LayoutTests/fast/borders/resources/svg-50x50-intrinsic.svg: Added.
* LayoutTests/fast/table/min-width-html-block-table-expected.txt:
* LayoutTests/fast/table/resources/min-width-helpers.js:
* LayoutTests/fast/table/min-width-html-inline-table-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-position/position-absolute-table-001-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/rendering/non-replaced-elements/tables/table-ua-stylesheet-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/rendering/non-replaced-elements/form-controls/resets.html:
* LayoutTests/platform/glib/tables/mozilla/bugs/bug145572-expected.txt:
* LayoutTests/platform/ios/tables/mozilla_expected_failures/bugs/bug3166-14-expected.txt:
* LayoutTests/platform/ios/tables/mozilla_expected_failures/bugs/bug3166-17-expected.txt:
* LayoutTests/platform/mac/tables/mozilla/bugs/bug145572-expected.txt:
* LayoutTests/platform/mac/tables/mozilla_expected_failures/bugs/bug3166-14-expected.txt:
* LayoutTests/platform/mac/tables/mozilla_expected_failures/bugs/bug3166-17-expected.txt:
* LayoutTests/platform/win/tables/mozilla/bugs/bug145572-expected.txt:

[karlcow]

I need to fix these 3 tests.

[pxlcoder]

Should we rename the bug/PR title to "Fix <table> box-sizing in UA stylesheet"? It doesn't look like this is actually about about <td> elements, and box-sizing is not an inherited property.

Would also be good to add a link to the spec in the commit message.

[karlcow]

1. Yes. I have done the PR title. I will do in the commit later.
2. Yes. will do.

Thanks!

[karlcow]

ok first test OpenSource/LayoutTests//fast/borders/border-image-fill-no-border.html

Top: test Bottom: text-expected.

From left to right: Safari, Safari (my build), Firefox, Chrome

[karlcow]

Ah my image test is not good enough. I need to re-work this is a bit. and I added two lines on expected files. I will fix it tomorrow.

[karlcow]

[karlcow]

ok I'm at lost here wrt tests failures

@nt1m There are two tests constantly failing whatever I do. https://ews-build.s3-us-west-2.amazonaws.com/Windows-EWS/4fda7ef5-146569/results.html

If I remove the NEWLINE it says it needs one. If I had one it says that there should not be.

I'm confused.

[karlcow]

After running the tests locally:

% diff ~/code/OpenSource/WebKitBuild/Debug/layout-test-results/fast/table/min-width-html-block-table-actual.txt ~/code/OpenSource/WebKitBuild/Debug/layout-test-results/fast/table/min-width-html-block-table-expected.txt

Without NEWLINE, FAIL

97,98c97
< TEST COMPLETE
< 
---
> TEST COMPLETE
\ No newline at end of file

With the NEWLINE, FAIL

98d97
< 

[karlcow]

🤦 two NEWLINEs

[karlcow]

ok remaining issue is the image

[webkit-early-warning-system]

EWS run on previous version of this PR (hash https://github.com/WebKit/WebKit/commit/7278a8bba9ac2c29ec57c09fa58740dcaa5fa939)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 🧪 win
✅ 🧪 bindings	✅ 🛠 ios-sim	⏳ 🛠 mac-debug	✅ 🛠 gtk	✅ 🛠 wincairo
✅ 🧪 webkitperl	❌ 🧪 ios-wk2	⏳ 🛠 mac-AS-debug	❌ 🧪 gtk-wk2
	✅ ~~🧪 api-ios~~	✅ ~~🧪 api-mac~~	✅ 🧪 api-gtk
	✅ 🛠 tv	✅ ~~🧪 mac-wk1~~
	✅ 🛠 tv-sim	✅ 🧪 mac-wk2
	✅ 🛠 watch	⏳ 🧪 mac-AS-debug-wk2
	✅ 🛠 watch-sim	✅ 🧪 mac-wk2-stress

[webkit-early-warning-system]

EWS run on previous version of this PR (hash https://github.com/WebKit/WebKit/commit/699e270b239fd047f8f756e334a5703aea25e4f8)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 🧪 win
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-debug	✅ 🛠 gtk	✅ 🛠 wincairo
✅ 🧪 webkitperl	❌ 🧪 ios-wk2	✅ 🛠 mac-AS-debug	✅ 🧪 api-gtk
	✅ 🧪 api-ios	✅ 🧪 api-mac
	✅ 🛠 tv	❌ 🧪 mac-wk1
	✅ 🛠 tv-sim	❌ 🧪 mac-wk2
	✅ 🛠 watch	❌ 🧪 mac-AS-debug-wk2
	✅ 🛠 watch-sim

[webkit-early-warning-system]

EWS run on previous version of this PR (hash https://github.com/WebKit/WebKit/commit/2dc8c86dd38a04ad24e5124a2da472872d02b7db)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 🧪 win
✅ 🧪 bindings	✅ 🛠 ios-sim	⏳ 🛠 mac-debug	✅ 🛠 gtk	✅ 🛠 wincairo
✅ 🧪 webkitperl	✅ ~~🧪 ios-wk2~~	⏳ 🛠 mac-AS-debug	❌ 🧪 gtk-wk2
	✅ ~~🧪 api-ios~~	✅ ~~🧪 api-mac~~	✅ 🧪 api-gtk
	✅ 🛠 tv	✅ ~~🧪 mac-wk1~~
	✅ 🛠 tv-sim	✅ 🧪 mac-wk2
	✅ 🛠 watch	⏳ 🧪 mac-AS-debug-wk2
	✅ 🛠 watch-sim	✅ 🧪 mac-wk2-stress

[webkit-early-warning-system]

EWS run on previous version of this PR (hash https://github.com/WebKit/WebKit/commit/699e270b239fd047f8f756e334a5703aea25e4f8)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 🧪 win
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-debug	✅ 🛠 gtk	✅ 🛠 wincairo
✅ 🧪 webkitperl	❌ 🧪 ios-wk2	✅ 🛠 mac-AS-debug	✅ 🧪 api-gtk
	✅ 🧪 api-ios	✅ 🧪 api-mac
	✅ 🛠 tv	❌ 🧪 mac-wk1
	✅ 🛠 tv-sim	❌ 🧪 mac-wk2
	✅ 🛠 watch	❌ 🧪 mac-AS-debug-wk2
	✅ 🛠 watch-sim

[webkit-early-warning-system]

EWS run on previous version of this PR (hash https://github.com/WebKit/WebKit/commit/1f57baf0aeb77ed74caa4ef3893a0d7a165b6650)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 🧪 win
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-debug	✅ 🛠 gtk	✅ 🛠 wincairo
✅ 🧪 webkitperl	✅ ~~🧪 ios-wk2~~	⏳ 🛠 mac-AS-debug	✅ 🧪 gtk-wk2
	✅ ~~🧪 api-ios~~	✅ ~~🧪 api-mac~~	✅ 🧪 api-gtk
	✅ 🛠 tv	✅ ~~🧪 mac-wk1~~
	✅ 🛠 tv-sim	✅ 🧪 mac-wk2
	✅ 🛠 watch	⏳ 🧪 mac-AS-debug-wk2
	✅ 🛠 watch-sim	✅ 🧪 mac-wk2-stress

[webkit-early-warning-system]

https://github.com/WebKit/WebKit/commit/2ec63def70f0d9135873e760777a9fc078986b9c

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ ~~🛠 mac~~	✅ 🛠 wpe	✅ 🛠 🧪 win
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ ~~🛠 mac-debug~~	✅ 🛠 gtk	✅ 🛠 wincairo
✅ 🧪 webkitperl	✅ ~~🧪 ios-wk2~~	✅ ~~🛠 mac-AS-debug~~	✅ 🧪 gtk-wk2
	✅ ~~🧪 api-ios~~	✅ ~~🧪 api-mac~~	✅ 🧪 api-gtk
	✅ 🛠 tv	✅ ~~🧪 mac-wk1~~
	✅ 🛠 tv-sim	✅ ~~🧪 mac-wk2~~
✅ 🛠 🧪 merge	✅ 🛠 watch	✅ ~~🧪 mac-AS-debug-wk2~~
	✅ 🛠 watch-sim	✅ ~~🧪 mac-wk2-stress~~

[webkit-early-warning-system]

EWS run on previous version of this PR (hash https://github.com/WebKit/WebKit/commit/699e270b239fd047f8f756e334a5703aea25e4f8)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 🧪 win
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-debug	✅ 🛠 gtk	✅ 🛠 wincairo
✅ 🧪 webkitperl	❌ 🧪 ios-wk2	✅ 🛠 mac-AS-debug	❌ 🧪 gtk-wk2
	✅ 🧪 api-ios	✅ 🧪 api-mac	✅ 🧪 api-gtk
	✅ 🛠 tv	❌ 🧪 mac-wk1
	✅ 🛠 tv-sim	❌ 🧪 mac-wk2
	✅ 🛠 watch	❌ 🧪 mac-AS-debug-wk2
	✅ 🛠 watch-sim	✅ 🧪 mac-wk2-stress

[nt1m]

Thanks!

[webkit-commit-queue]

Committed 253581@main (8915be4c0470): https://commits.webkit.org/253581@main

Reviewed commits have been landed. Closing PR #2800 and removing active labels.