Peter W

Results 15 comments of Peter W

I think we should start pointing examples at `latest` or a recent versioned release probably, since that alpha is sort of frozen in time at the moment and I don't...

@aqemery this explains the versioning and reasons for it: https://anaconda.cloud/announcing-pyscript-versioning TLDR: If you want to track the main branch of this repo, it's `unstable`. `latest` is latest Alpha, and then...

We actually do use it but it's part of pre-commit https://github.com/pyscript/pyscript/blob/571bb2b2948435f36e94b6c3a6253c560e346279/.pre-commit-config.yaml#L67

My other PR #696 is looking to get rid of `make example` anyhow although I'm not quite sure if it'll work as I want it to. But basically we `make...

Hm the integration test failed although it's up to date with `main`. Weird. `FAILED tests/integration/test_zz_examples.py::TestExamples::test_repl2[chromium]` This changes no base code so I'd really, really expect it to pass since the...

Apparently because it passed this time 🤷🏼

I think that all makes sense. If we had proper tests that made show examples worked properly instead of simply loaded at all, then pointing them to latest would probably...

I guess I should have said they'd be more likely to catch broken tests when they occur, but yes they would not provide a fix and therefore block deployments. So...

Thank you @fpliger, I agree with all of that. I forgot the fact that we had changed the example sync to pyscript.net https://github.com/pyscript/pyscript/pull/623 so that the publicly-hosted examples there should...

Well the tests as they exist currently don't actually make sure examples work correctly, just that they've rendered in some way or another. So it'll allow deployments to go ahead...