Patrick Way

Results 63 comments of Patrick Way

thanks @yeikel, this is very helpful

Hi @yeikel, The recipe should be removing the vintage engine https://github.com/openrewrite/rewrite-testing-frameworks/blob/18fb857949e539993fc48785b00a66896d244fad/src/main/resources/META-INF/rewrite/junit5.yml#L90-L92 Can you try the latest build and let me know if it's still an issue?

>Is org.openrewrite.java.testing.junit5.JUnit5BestPractices the one I should try? `Junit5BestPractices` invokes `JUnit4to5Migration` so it should remove the vintage engine dependency https://github.com/openrewrite/rewrite-testing-frameworks/blob/18fb857949e539993fc48785b00a66896d244fad/src/main/resources/META-INF/rewrite/junit5.yml#L26 >Adding it as an exclusion is not a good practice. A...

I think a standalone recipe is a good option, the [AddPlugin](https://github.com/openrewrite/rewrite/blob/main/rewrite-maven/src/main/java/org/openrewrite/maven/AddPlugin.java) should make it a fairly simple addition to the junit recipes

Re-Opening given that 7.17.0 has better JavaType information

Thanks for the detailed issue @nmck257! We'll have a look

It may be possible to configure a declarative recipe for this migration. These may help [ReorderMethodArguments](https://github.com/openrewrite/rewrite-docs/blob/master/reference/recipes/java/reordermethodarguments.md), [ChangeType](https://github.com/openrewrite/rewrite-docs/blob/master/reference/recipes/java/changetype.md), [ChangeMethodTargetToStatic](https://github.com/openrewrite/rewrite-docs/blob/master/reference/recipes/java/changemethodtargettostatic.md)

@tkvangorder @yeikel for the Apache commons IOUtils task I handled all charset specific deprecations in a single recipe f758efb62aa4dea938841766a81fd1d14d44c321

for: https://github.com/openrewrite/rewrite-migrate-java/tree/main/src/main/java/org/openrewrite/java/migrate/apache/commons

CXF supports Java 9-11 starting with the [3.3.x](https://cxf.apache.org/faq.html#FAQ-CanCXFrunwithJDK/Java9+(10,11)?) release.