Patrick Way

Results 63 comments of Patrick Way

Wrong encoding for Java source files with ISO-8859-1

Hi Thomas, I have put up a rewrite-maven [PR](https://github.com/openrewrite/rewrite-maven-plugin/pull/421/files) for setting the charset from mavens `sourceEncoding` property, and working on a rewrite-java solution that will use the maven-plugin charset when...

Remove unused private classes

Hi Tom, This is a good suggestion

Remove unused private classes

Thanks Tim!

Groovy Parser Error breaks custom gradle task

@edward3h, thanks so much for the sample project!

Groovy Parser Error breaks custom gradle task

this looks like a groovy parsing error, its showing up in the `EmptyNewlineAtEndOfFile` recipe because it changes the file. check out the TypeCast expression below: ![image](https://user-images.githubusercontent.com/22326988/190512380-fef3d009-61a5-44bc-8c48-a2b8b76de06d.png)

Expected a template that would generate exactly one statement to replace one statement, but generated 2

@ZzetT I am closing this one since the related issue https://github.com/openrewrite/rewrite/issues/2090 has been completed. Please re-open if the bug persists.

Expected a template that would generate exactly one statement to replace one statement, but generated 2

Thanks for the clarification, @ZzetT. I'm unaware of a fix for the JavaDoc issue and will re-open this one.

Rule: S2325 Methods that don't access instance data should be static

data-flow should not be necessary for this one, the spec is specific for non-overridable methods that don’t access instance data.

ImportLayoutStyle doesn't work as expected

Hi @tisonkun, looking at your config `org.openrewrite.java.format.AutoFormat` does not order imports, can you try again with the `org.openrewrite.java.OrderImports` recipe added to the configuration?

ImportLayoutStyle doesn't work as expected

Thanks @tisonkun, I will have a look