Peter Van den Bosch

Results 188 comments of Peter Van den Bosch

To make reviewing easier, I've uploaded the Swagger schemas to a dedicated repo: https://github.com/belgif/rest-guide-example I'll put feedback in issues there, and stop reviewing it in this issue

there's a new version of the contracts in OpenAPI 3 which we'll go ahead with. There's a JAX-RS implementation of it not depending on internal Smals tooling. Implementation will be...

work has resumed on the demo API. OpenAPI 3 schema updated on https://github.com/belgif/rest-guide-example Next steps: * finish implementation * deploy demo API (which URL? e.g. https://rest-guide.gcloud.belgium.be/demo/v1 or https://rest-guide-demo.gcloud.belgium.be/employers/v1 ) *...

Implementation is finished, but demo API not published yet; infrastructure is being set up. I updated the OpenAPI files on https://github.com/belgif/rest-guide-example Proposed URL: https://rest-guide.gcloud.belgium.be/demo/v1/

openapi file was updated in https://github.com/belgif/rest-guide-example following recent github issues; still working on publishing the demo API

WIP list of impact on styleguide: * nullable support => something better than empty placeholder type for JSON Merge Patch? => https://github.com/belgif/rest-guide/issues/189 * **styleguide updated** media type can be specified...

Opened new issues for open points: * examples: https://github.com/belgif/rest-guide/issues/188. The remaining ones without ticket * nullable: https://github.com/belgif/rest-guide/issues/189 I haven't seen much use cases where the links feature would be worthwhile;...

OK for WG to add Apache License 2.0 in all belgif openapi files.

license added for employment-identifier (while changing it for another issue): * https://github.com/belgif/openapi-employment-identifier/blob/master/src/main/openapi/employment/identifier/v1/employment-identifier-v1.yaml * https://github.com/belgif/openapi-employment-identifier/blob/master/src/main/swagger/employment/identifier/v1/employment-identifier-v1.yaml TODO for other openapi repos

Additional properties (using a specialized Problem subtype are not) are always allowed; the guide can't exhaustively list every possible use case. Though this use case may be common enough to...