Peter Van den Bosch
Peter Van den Bosch
In GitLab by @pvdbosch on Jan 22, 2019, 11:47 The API used for internal Smals trainings is going to be used as mock API. @smals\-wisa , could you share it...
In GitLab by @pvdbosch on Dec 11, 2019, 15:03 A Smals developer will work on this. Try to get it done in two months, then update examples in guide. @wsalembi...
work is in progress, cutting socsec (Smals)-specific dependencies
@wsalembi , can you attach the swagger file of the demo API?
* /doc/schemas/{name} can be removed * align terminology: * cbeNbr => enterpriseNumber * companies => organizations or registeredOrganizations * cbe often uses 'entity' in its doc, but in fedvoc international...
I did a review of the Swagger: * beginDateGT => beginDate_gt cfr #18 (guideline not published yet, but was confirmed a long time ago in WG) * names and types:...
I got some broken references when opening swaggerSuggestion.yaml: ``` There was an error while processing your files. Please fix the error and save the file. #/paths/~1refData~1employerClasses/get/responses/200/schema/items: JSON Pointer points to...
Some more feedback: * response status codes should be string instead of number: e.g. "200" instead of 200 https://github.com/OAI/OpenAPI-Specification/blob/master/versions/2.0.md#responses-object-example * Could use /health path in common-v1.yaml instead of your own....
Hi, @smals-chlo , definition of status code as integer in the Problem JSON schema is OK, but in the Swagger schemas where you define the JSON schema for each response...
Hi @smals-chlo , can't the gcloud schema files be referenced as-is? I see their types are copied and split now across different yaml files. This is an example of one...