Patrick Valsecchi

Results 37 comments of Patrick Valsecchi

But, for `externalGraphics`, looking at the code, the `parseExpression` method doesn't seem to be called: https://github.com/mapfish/mapfish-print/blob/728622bb3444c1faad72dd6f41dadfb53a649332/core/src/main/java/org/mapfish/print/map/style/json/JsonStyleParserHelper.java#L190 And this line didn't change for the last 4 years. If you look at...

Yes, you are right @margitbomholt. From what I see in the code, `failOnError` is used only for tiled layers. So yes, we should include non-tiled and vector layers.

As far as I know, there is no additional setting needed on the server side.

#834 improved a bit the situation, here.

No, we don't work on version 2 anymore. But, usually PRs are welcome and we can do releases for those.

Yeah, cicrcleci doesn't work with this branch. But I don't understand why travis didn't trigger... I leave for vacation in a few hours and won't have time to deal with...

Or @sbrunner, can you have a look?

Is it still the case?