mapfish-print icon indicating copy to clipboard operation
mapfish-print copied to clipboard

FailOnError for legends

Open pvalsecc opened this issue 8 years ago • 6 comments

Unlike the map tiles, when legends are failing, we cannot make the print fail.

pvalsecc avatar May 10 '16 09:05 pvalsecc

We haven't been able to get the print fail, on errors, eg. wrong layer name/or service not responding, even though we have added a boolean property "failOnError" to the layer in the son request. Do you know whether that should be possible?

margitbomholt avatar Jun 16 '16 13:06 margitbomholt

Yes, you are right @margitbomholt. From what I see in the code, failOnError is used only for tiled layers. So yes, we should include non-tiled and vector layers.

pvalsecc avatar Jun 17 '16 05:06 pvalsecc

Thank you for answering. In our test we have used tiled WMS layers, but we haven't managed to get any error messages.. Is there any settings that has to be done on the mapfish server,? A snip of our request json : {"baseURL":"http://kortforsyningen.kms.dk/service","customParams":{"login":"xxx","password":"xxx","servicename":"topo_fot","VERSION":"1.1.1","TRANSPARENT":"true","LAYERS":"basis","SERVICE":"WMS","SRS":"EPSG:25832","buffer":50,"TILED":"true"},"layers":["basis"],"opacity":1,"styles":[""],"type":"WMS","failOnError":true}.

margitbomholt avatar Jun 17 '16 09:06 margitbomholt

As far as I know, there is no additional setting needed on the server side.

pvalsecc avatar Jun 20 '16 06:06 pvalsecc

#834 improved a bit the situation, here.

pvalsecc avatar Feb 27 '19 07:02 pvalsecc

Hello, Thanks for this work, I have made an additional modification to manage exchange with QGisServer. When Layer name does not exist on qgiserver, QgisServer will respond with http 200 btu with some XML.

I have made a PR #996, review is welcome :)

pierrejego avatar Jul 18 '19 14:07 pierrejego