Pushp Ranjan
Pushp Ranjan
@jasperjiaguo I can get started on this, if it's not yet been picked up.
Yes I can pick up both the issues, will get back with queries if any
Hi @jasperjiaguo Sorry I was inactive here owing to some personal commitments. I went through the code and have below findings for **1** **Existing flow** `BaseTableDataManager.downloadSegment() -> downloadSegmentFromDeepStore() -> downloadAndDecrypt()...
@jasperjiaguo can you please take a look at this PR for issue [1]: https://github.com/apache/pinot/pull/10411 I don't seem to have permission to link this issue to PR or add labels.
Thanks for the revert @jasperjiaguo , above PR has received some feedback comments from team members and I am working on the refactoring.
@s0nskar wondering if are you still pursuing this, else will go ahead and give it a shot
@harold-kfuse, based on my analysis I see that 1. [PinotSegmentUploadDownloadRestletResource](https://github.com/apache/pinot/blob/d8315c6025fbe963a9c01c08e0b021e54ae318d9/pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotSegmentUploadDownloadRestletResource.java#L280) already has code to handle segment METADATA, I assume the same endpoint can be used for `BaseSingleSegmentConversionExecutor` also 2. [BaseMultipleSegmentsConversionExecutor](https://github.com/apache/pinot/blob/d8315c6025fbe963a9c01c08e0b021e54ae318d9/pinot-plugins/pinot-minion-tasks/pinot-minion-builtin-tasks/src/main/java/org/apache/pinot/plugin/minion/tasks/BaseMultipleSegmentsConversionExecutor.java#L355)...
Thanks @Jackie-Jiang , I was able to go through the code and get that part. Let me share the PR once its ready.
Hey @ceekay47 please feel free to pick this up