Puridach wutthihathaithamrong

Results 10 comments of Puridach wutthihathaithamrong

Run: superset db downgrade ![Screenshot 2566-12-21 at 12 53 24](https://github.com/apache/superset/assets/76474644/750a6d56-46ee-4f8f-b726-836a0d691b91) Run: superset db upgrade ![Screenshot 2566-12-21 at 12 53 35](https://github.com/apache/superset/assets/76474644/055826eb-86e5-4026-8913-fcf703ccf1a4)

> ## [Codecov](https://app.codecov.io/gh/apache/superset/pull/26327?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report > Attention: `6 lines` in your changes are missing coverage. Please review. > > > Comparison is base [(`8c32c6d`)](https://app.codecov.io/gh/apache/superset/commit/8c32c6da169afec312923e516850d90a69e78f46?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 69.18% compared to head [(`f7c7a9a`)](https://app.codecov.io/gh/apache/superset/pull/26327?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 59.04%. >...

@giftig @john-bodley Could you please help me review this PR again?

Ping @eschutho I have already modified the code based on your comment.

Ping @eschutho Could you please help me review this PR again?

Ping @eschutho Could you please help me review this PR again?

> http://18.246.236.152:8080 > /testenv up FEATURE_ALERT_REPORTS=true FYI, I still haven't edited the code from yousoph comment. But I appreciate your care and attention. Thank you very much.

Ping @eschutho @geido I request another review of my PR? Thank you!

> Hey @puridach-w doing some manual testing. It seems that the spacing is off here > > ![Screenshot 2024-03-11 at 16 41 35](https://private-user-images.githubusercontent.com/60598000/311766440-0cb4cb82-3a51-4712-8eab-31866e8479c6.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTAyMzE0MDEsIm5iZiI6MTcxMDIzMTEwMSwicGF0aCI6Ii82MDU5ODAwMC8zMTE3NjY0NDAtMGNiNGNiODItM2E1MS00NzEyLThlYWItMzE4NjZlODQ3OWM2LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDAzMTIlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwMzEyVDA4MTE0MVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWM1ZGU5ZTIwYzJkODYzMzQ1ZDk1MTM2ZmU3MmNkZTZhMzljNTlkNDU2NGFjY2NlN2I4YTM4MzljOGMzNWQ5M2QmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.shy0MrxbWvoSSYaXT_iL2Kio5bN-LFuC3Dd8gBQYYSU) Hi @geido, the modifications have been completed....

> Hey @puridach-w if you look at the testenv above, you will see that there is a` :` in the placeholder. I think something might be broken in the placeholder...