Varun Patil

Results 521 comments of Varun Patil

Ah, they need CORS. My comment was premature then; I need to look more closely at what this news app is doing.

This needs to be reviewed commit-by-commit for the diff to make any sense.

Gonna take a leap of faith on this one. Let's release an unstable version and hope people catch any new bugs. @azmeuk

Apologies. He authored the commit that got broken (https://github.com/nextcloud/viewer/commit/a05dbf35c05c77efbc273986bcd92c89ee745499) so I thought he might know better.

> Currently nothing is broken Do you mean https://github.com/nextcloud/photos/issues/1440 is fixed? That's what this PR was meant to address. > I'm still not ok with adding custom app-oriented conditions in...

Your nextcloud instance should be able to reach `https://auth..com/.well-known/openid-configuration`, which should have the JSON something like [this](https://contoso.auth0.com/.well-known/openid-configuration). Is this the case?

Sounds good. This needs to be configurable since it potentially opens up attack vectors. If the IdP has a user `azmeuk`, then I can create another user `àzmeuk` in the...

Encrypted storage "behaves" like external storage. Basically transcoding is disabled for external storage since the entire file needs to be downloaded to the temp directory, and this is horribly slow...