Pulkit Singhal

Results 49 comments of Pulkit Singhal

@ernie58 - Hey boss! thanks for reporting this, sorry that I missed it until today, so ... thanks again for the re-ping! Will work on this on the weekend.

>You want me to make a PR? @ernie58 - yes that would be super.

FYI see above cc @aquid @wolfgang-s

You use case is interesting and possible because the source code doesn't tie down the underlying driver to a specific `index` so it should be possible to do this. Made...

In chat I had mentioned: > Pulkit Singhal @pulkitsinghal Aug 14 17:45 > to search on a new index every time doesn't have much to do with searching on different...

@0candy, @jannyHou, @superkhau and @bajtos - I wanted to enable users of this elascticsearch connector to build "dynamic indexes" by providing a function in the `datasources..js` file: ``` module.exports =...

cc @onstrike07 and @juanpujol - the comment above highlights my latest plan for enabling dynamic indices. Along with a minor change to: ``` ESConnector.prototype.addDefaults = function (modelName) { ... //...

@bajtos and @superkhau - thank you! And a have one follow up question about testing. 1. Usually in connector test files, I'm setup via: `var settings = require('./resource/datasource-test.json');` 2. In...

I want to take a moment to point out the fact that @onstrike07's code used caching because of global variables being reused. Caching is something which I should give some...

thank you for your earlier comments @superkhau