Jonathan Puckey comments

Results 97 comments of


                                            Jonathan Puckey

[Feature Request] autodetect HLS & Dash

@jspizziri do you want to give this pr a try: https://github.com/doublesymmetry/react-native-track-player/pull/2525/files

Nitrogen crashes with self-referential struct types (Maximum call stack size exceeded)

Thanks for the explanation! Updated the PR with a more helpful error message that shows examples of both direct and indirect cyclic references, plus a link to some added docs...

Nitrogen crashes with self-referential struct types (Maximum call stack size exceeded)

Hmm actually there are still stack overflow issues happening with valid non-cyclic patterns like structs containing callbacks that reference the same struct type: ```typescript export interface RequestConfig { transform?: (request:...

Nitrogen crashes with self-referential struct types (Maximum call stack size exceeded)

I've opened a (Claude Code assisted) PR to address this: #1074 The fix handles cyclic struct references by: 1. Detecting direct/indirect recursive structs (A→A or A→B→A) and throwing a clear...

feat(nitrogen): Improve error message for cyclic struct references

Closing in favor of #1074 which includes this improvement along with proper cyclic dependency handling.

test: add SelfReferentialStruct test case

For this case I expected it to be possible, or is it something you don't want to support: ```ts export interface SelfReferentialStruct { transform?: (config: SelfReferentialStruct) => Promise } ```

test: add SelfReferentialStruct test case

Closing in favor of #1074 which includes this test case along with a fix

Requiring unknown module "2537"

@jspizziri perhaps you have an idea on this

fix(android): update queue with current track

Thanks for the pr - this is indeed the fix, but can be done shorter using `replaceItem`: https://github.com/doublesymmetry/react-native-track-player/pull/2527/files

Wrong AddTrack type definition

Happy to review a pr for this