Jonathan Puckey

Results 97 comments of Jonathan Puckey

We can infer the type instead. Note that the following also improves the type for events that do not expect an event object. ```ts function addEventListener( event: T, listener: EventDataByEvent[T]...

@jspizziri No it wouldn't – the type is inferred:

See here for my additional changes to this PR: https://github.com/doublesymmetry/react-native-track-player/pull/1640

The only way I was able to get functioning shared schema types across packages in our yarn 2 monorepo was to: - duplicate the `schema.d.ts` file to a `schema.ts` file...

Thanks @jawj! Since my earlier solution didn't work, I took another look at @sfsr12's solution and was able to simplify it a bit: https://github.com/sfsr12/zapatos-example/pull/1 This has zapatos generate its type...

Thanks for this PR @ezze – it solved the issues I was having.. I hope it gets merged at some point.

PR here: https://github.com/AnalyticalGraphicsInc/cesium-webpack-example/pull/9

See https://github.com/ditojs/dito/pull/34 I was wondering about logging defaults: how about having some turned on in development and disabling by default in production?

We could use the defaults used in `dito-example`... In production everything is turned off and in development we have: ``` log: { requests: false, routes: false, schema: false, relations: false,...

I was also able to fix this by removing the original `mediaSessionConnector.setMediaMetadataProvider` call. See https://github.com/doublesymmetry/KotlinAudio/pull/54/commits/9db93a959387485cadfbe29d2cce199b52e1eb5f It seems that it was causing exoplayer to update the notification as well. @mpivchev I...