ptth222

Results 23 comments of ptth222

The only conflict is where I deleted a line in testing that was printing. Can this be resolved?

What issue? I addressed everything mentioned in the history above, and all of the tests pass. If there is an issue can we create a test for it?

Thank you for the reply. I think I understand a little better. We have something similar built into MESSES, but it is strictly optional. If the user wants to validate...

Hunter's schedule is a little hectic right now, but we could meet at either of these times this week: Tuesday Jan 30th 10:00 AM EST Wednesday Jan 31st 12:00 PM...

It looks like some of the tests are specifically looking for the messages to be warnings. If it is agreed that these should be errors I think those tests have...

Adding my last commit message here: There were quite a few changes because warnings became errors in a lot of tests. isa_tab/validate/test_core.py test_b_ii_s_3: The old warnings were: ``` [{'message': 'Protocol...

The lines from the new commit need to be accepted. The tests had to change since this code changed a warning to an error.

Turned out neither of the lines worked. The DOI fix wasn't merged in yet I think. That fix reduced the warnings by 2, so I fixed the tests appropriately.

I made new commits to #510 to address what you said. I hope it is better. I also discovered another issue while making these changes. There are some inconsistencies between...

I assume for the PR you are talking about issue #501. I have created a PR for that issue. For this issue I am not convinced that the study file...