Paolo Tosco

I’ll try and run the workflow locally on my Windows and Mac Silicon boxes and see if I can figure out what’s wrong. I’ll hardly have any time before the...

@greglandrum I have simply disabled compiling `Code/GraphMol/RGroupDecomposition/GaExample.cpp` for CFFI and MinimalLib builds. I have also reverted the `maeparser` patch which is not necessary anymore after version 1.3.2 was released. Tomorrow...

> The description of the PR should also include the introduction of `PNGMetadataParams` and the associated improvements to the metadata addition functions Done and solved the merge conflicts.

@greglandrum Thanks for checking. I'll try and figure out what triggers that behavior in my build environment.

@greglandrum @jasondbiggs Yes, this seems to be a bug in `ResonanceMolSupplier`, possibly connected to #4491. I'll try and take a look.

@StLeonidas Thank you Leonid, I will review over the weekend.

@ricrogz As we discussed at the UGM, this is what the "dative bond" PR that I am working on deals with. However, changing the value returned by `getValenceContrib()` for `Bond::DATIVE`...

This is diff between the test output before and after this PR; as expected, the only differences involve the test case with pre-existing mapped non-dummy atoms, which in my opinion...

I agree that the current `master` behavior is correct. The molecule ``` RDKit 2D 0 0 0 0 0 0 0 0 0 0999 V3000 M V30 BEGIN CTAB M...

> I'm a bit uncertain, mainly because of the "maybe" part. I see how `[[maybe_unused]]` can help in those situations where a variable may be used or not depending on...