Philip Chimento
Philip Chimento
> @jugglinmike I do think it would've been more convenient to develop these in the proposal-temporal repo in order to get code coverage metrics, and then move them over to...
@jugglinmike Any comments on the above idea to copy over all the tests from tc39/proposal-temporal to tc39/test262 all at once? I can make this PR but I don't want it...
Hi @rwaldron! I think my concern is actually the opposite — I don't want two sets of tests, only one! We would like to delete the tests from tc39/proposal-temporal as...
Thanks, that's great news! I am on vacation tomorrow, so will make this pull request as soon as possible on Monday. If you would like to plan a Matrix chat...
OK, thanks! In that case I won't prioritize the pull request today, but I'll make sure to send it by Wednesday. Does that sound good to you?
I think this was resolved by #3377.
I approved this a while ago, no other reviews after mine, and Jordan's comment has been addressed; I think we should merge it.
> > I didn't go through everything, but I did verify a big chunk of these — would you prefer to keep everything together in one PR or would you...
My plan for following up: 1. Separate out the tests that are affected by the recently adopted Temporal normative changes, update them to reflect the changes, and merge them at...
Sorry it took so long. I've reviewed another batch of these and they're ready to land in https://github.com/tc39/test262/pull/3677. Once that is merged, I'll rebase this again and review the remaining...