test262
test262 copied to clipboard
Import SpiderMonkey Temporal tests
Temporal tests written for the SpiderMonkey implementation. Mostly covers edge cases around mathematical operations and regression tests for reported spec bugs.
Linter fails - I think you're missing the year in your copyright headers
I didn't go through everything, but I did verify a big chunk of these — would you prefer to keep everything together in one PR or would you like me to commit the ones that I've done already?
It's all the same to me. Let's do whatever works best for you.
I didn't go through everything, but I did verify a big chunk of these — would you prefer to keep everything together in one PR or would you like me to commit the ones that I've done already?
It's all the same to me. Let's do whatever works best for you.
I've done this in #3606.
My plan for following up:
- Separate out the tests that are affected by the recently adopted Temporal normative changes, update them to reflect the changes, and merge them at the same time as the corresponding normative PRs
- Then, review everything else that's not number precision issues
- Save the most difficult work for last :stuck_out_tongue_closed_eyes:
@anba, if you have time to do the updates for (1) I'd appreciate it, otherwise I'll get around to it sometime this week or next.
@anba, if you have time to do the updates for (1) I'd appreciate it, otherwise I'll get around to it sometime this week or next.
I've added the following four commits:
- The first one updates a test which uses negative day lengths.
- The other three commits address review comments from your first review.
Sorry it took so long. I've reviewed another batch of these and they're ready to land in https://github.com/tc39/test262/pull/3677. Once that is merged, I'll rebase this again and review the remaining 5 tests. I expect to be able to get to that early next week.