Philip Chimento comments

Results 272 comments of


                                            Philip Chimento

Avoid nonstandard use of names for types in wit-0.3.0-draft

Sure, I can review that.

Compatibility with Hardened JavaScript

This has a formal approval and a couple of additional approvals. Can we merge it or was anyone else planning to review it?

Run global=shadowrealm tests in ShadowRealms created in multiple scopes

cc @Ms2ger @mgaudet @smaug----

Run global=shadowrealm tests in ShadowRealms created in multiple scopes

PR: #49108

Provide HostEnsureCanCompileString implementors more context

I've opened a rebased version of this over at https://github.com/tc39/ecma262/pull/3222.

Should test262/test/intl402/DateTimeFormat/offset-timezone-no-unicode-minus-sign.js fail ONLY if offset time zones are supported?

Seems like a good suggestion to me. We don't usually write tests like this in test262 but the argument that it will otherwise never get taken off of implementations' skip...

Minor fixes to readable-streams tests for ShadowRealm

Thanks for the review! Should have all of the feedback incorporated now.

Minor fixes to readable-streams tests for ShadowRealm

Appreciate the reviews!

Ignore exit code of clang-format-diff

Note, clang-format-diff 18.x has another regression: https://github.com/llvm/llvm-project/pull/86776 This causes the `test_two_files` tests to fail, but it is unrelated to this change. Hopefully they will backport the fix soon.

Temporal: Add coverage for BubbleRelativeDuration called with time unit

cc @anba