wpt icon indicating copy to clipboard operation
wpt copied to clipboard

Minor fixes to readable-streams tests for ShadowRealm

Open ptomato opened this issue 1 year ago • 1 comments

A few fixes for readable-streams tests with incorrect expectations for ShadowRealms:

  • Don't execute the test that depends on VideoFrame in ShadowRealm, since VideoFrame isn't exposed there.
  • For the test resource file that depends on setInterval, provide a "fake" implementation if setInterval/clearInterval aren't present on the global object, which is the case in ShadowRealm.

Reported by @mgaudet in https://github.com/tc39/proposal-shadowrealm/issues/396

ptomato avatar Oct 16 '24 19:10 ptomato

Thanks for the review! Should have all of the feedback incorporated now.

ptomato avatar Oct 17 '24 19:10 ptomato

Appreciate the reviews!

ptomato avatar Oct 21 '24 18:10 ptomato