Philip Chimento comments

Results 272 comments of


                                            Philip Chimento

Dependency of async-gc helper on cleanupSome functionality

The `cleanupSome` proposal has been withdrawn as of the 2023-09 TC39 meeting.

Add tests for RoundDuration when unit is "month" and the fractionalDays sign gets flipped

@anba Thanks for another excellent test case. In tc39/proposal-temporal#2612 note that we actually are removing this loop: https://github.com/tc39/proposal-temporal/pull/2612/commits/705daa3e4b927c2ef1c60c66f2d7e329e6bd7db3 (commit needs a rebase, but you get the idea.) The RoundDuration algorithm...

Tests for regular expression modifiers

> I find it strange that such an asymmetry exists. A quick test of the same pattern in both modes in C# shows no asymmetry, so it's not clear to...

Tests for regular expression modifiers

The merged PRs have covered the entire testing plan, so this is done!

Add tests for the RegExp Modifiers proposal

Thanks for asking! What I think will need to happen here, that you could help with, is: - Compare this PR with #3807 (which contains syntax tests for this feature)...

Test coverage for Intl.DisplayNames.prototype.of()

@ben-allen What is keeping this a draft?

Increase coverage of String.prototype.replace $xy replacement patterns

This normative change got consensus conditionally in the 2023-09 TC39 plenary meeting. "If there is a mismatch between engines, the presenter should bring the change back to TC39 to discuss...

Increase coverage of String.prototype.replace $xy replacement patterns

Thanks. So does that mean there are no longer any blockers for this?

Helpers should be documented in or from CONTRIBUTING.md

@kulsoomzahra That's great to hear you are interested! Generally you don't need to ask permission to work on it. Just go ahead! If you have questions, drop by our chat...

Fix test generation placeholders inside and adjacent to RegExp literals

@jugglinmike I see your point, in fact I shared your skepticism about the configurable delimiters feature when Richard suggested it. [This comment](https://github.com/tc39/test262/issues/3808#issuecomment-1509221736) explains why I changed my mind. But like...