Philip Chimento

Results 272 comments of Philip Chimento

While waiting for a review ... seems like the CI is failing due to invalid front matter in `test/language/statements/await-using/Symbol.asyncDispose-getter.js`, mind taking a look? Please also check the [linter output](https://app.circleci.com/pipelines/github/tc39/test262/5110/workflows/8236c3a8-239f-4071-b988-fdef6f645d81/jobs/47337).

Thanks! Added some suggestions from examining the existing tests for `Promise.all`.

Sure, for the first item in the sub-list ("throws"): I meant we should test the case where the function body of the receiver's constructor throws an exception. Like this: ```js...

@CanadaHonk, this is amazing! Thanks. I think it'll be quite difficult to review effectively by hand, so my preference would be that we just rely on the ESMeta checks, and...

> will check results of engines with new changes. FYI, the results of the CI jobs don't say whether any tests failed (it's often expected that tests will fail in...

@CanadaHonk It's been a while, so sorry for the delay, but could you check the ESMeta results again? Since this is a long and repetitive PR we should make sure...

I guess the context for this question was [my comment in this WPT pull request](https://github.com/web-platform-tests/wpt/pull/41760#issuecomment-1703256661)? I don't think we need to shift tests to WPT as such, but since we...

One place where compatibility issues arise with ILD string changes is from serializing and rehydrating web pages. As an example of an engine where that isn't a concern: I'm involved...

Yes, the same thing could happen, but when you re-parse an ILD string in an app I think you're probably more likely to be aware you're doing something iffy. Anyway,...