Mai Minh Pham
Mai Minh Pham
Our club only started using Spond late 2023 so I'll have to check out the links above to see what the migration is about. However, afaict, it does seem like...
> For now - does this imply that other API endpoints (and the rest of the library) still work for you, but the club API endpoint provides additional functions? Correct....
> I have not tested the "club" functions, but if it is possible to unite the functions from the two endpoints without to many conflicting names I would prefer to...
I took a stab... Having both of them in the same class is difficult since we'll need two separate tokens to authenticate! Therefore, I opted for 2 separate classes and...
This PR ended up containing more features than originally intended. :)
@elliot-100 thanks for flagging the isort check. All done!
Just took a quick look at #114 too, do I also need to update README.md with additional features implemented in this PR (i.e. `get_export`, `get_transactions` and `change_response`)?
> Yes, please update the README. Sure, done! :heavy_check_mark: > Also, since the PR contains quite some refactoring of thr base class, I think we should look into merging a...
Done rebasing on top of current `main`
yep, all set, whoever has write access please rebase or merge onto main! :rocket: Thanks for the review @elliot-100 ! :100: