Phil Ting

Results 8 comments of Phil Ting

I also agree with the proposal for separate rules. When I turn on `exhaustive-deps` I don't really expect any messages on async usage. They seem like completely different concerns to...

At the moment, the rule runs a check for `isEffect` which is essentially a regex match for `Effect`. Rather than assuming that effect hooks will be named `use.*Effect`, I think...

I agree. I think that `resolve('/path/to/dir')` and `normalize('/path/to/dir')` should produce the same output. Also think `common` should omit trailing slashes as well. If you look at the Go std library...

> The expectations in only_test.ts looks good to me, but let's not consider flat test grouping nested inside other suites like the below: The specific one you mentioned is actually...

> Observe that all of the tests still run. @chooie I believe `only` is scoped to the file, so running the entire test suite via `deno test --allow-write --allow-read` will...

I'll be trying out a solution for this one.

~Seems strange that `Response` is defined but `Headers` is not.~ ~In addition to either of the suggested fixes, we should remove the custom interface for `Response` altogether. That should be...