mallocMC icon indicating copy to clipboard operation
mallocMC copied to clipboard

fix few bugs

Open psychocoderHPC opened this issue 1 year ago • 1 comments

  • fix double page clean-up()` was not taken into account
  • fix that the page lock during `tryUsePage

@chillenzer could you please have a look if you observe any logical issues.

psychocoderHPC avatar Jun 17 '24 09:06 psychocoderHPC

Looks okay to me. In contrast to my version, you've only got 2 calls to tryCleanPage when it's 4 in my case. One of them is when trying out pages. Because you never "enter" a page (increasing filling level) while searching around, you don't take responsibility for cleaning up. The other one is the multi-page mode which does this by hand.

Apart form that, the structure seems to be very similar.

I will check tomorrow for the cases where the full page is used. Since in this implementation chunksize is checked before increasing the fill level the number of calls to try clean can differ.

psychocoderHPC avatar Jun 18 '24 09:06 psychocoderHPC

I checked if tryCleanPage is called where it should The multi page allocation for large chunks is not using the fill level. It uses the chunksize only therefore tryCleanPage is not required.

psychocoderHPC avatar Aug 07 '24 13:08 psychocoderHPC