pspizzo
pspizzo
> So first this is that there's an almost exact copy of your `PKCEAuthenticationPage.js` already in the [repo](https://github.com/decaporg/decap-cms/blob/86d41d79b20583041570bce30b46835a36bcecf2/packages/decap-cms-backend-aws-cognito-github-proxy/src/AuthenticationPage.js). It's also claimining to be generic but in it's not in practice....
I updated the PR with some refactoring and some improvements: - I moved the PKCE and Netlify auth pages to a new UI library, so identical auth pages do not...
Thanks for the approval. I think I need a maintainer to also approve the workflows, so they can run before the code is merged.
There were merge conflicts with a recent commit to main, so I resolved the conflicts and repushed my branch. Please re-review.
This has been sitting open for too long again, so new merge conflicts crept in. I merged the latest from main into my fork/branch, but I haven't had time to...
Now that the changes are approved and all checks have passed, what is the next step to get it merged?
@samo4 I had to merge from main again, can you re-approve this request?
Thanks @samo4 for approving the changes. Do you mind approving the workflows, so the automated builds can run?
> Just wanted to say great work with this one, thanks to this, SSO flows have now become possible with DecapBridge 🎉 I'm glad you found it useful!