Simon Bennetts

Results 660 comments of Simon Bennetts

I'm in 2 minds about the `Enabled` checkbox in the dialogs - I dont think we really need it, but I also think its a bit strange not being able...

@dossantospat thanks for the nudge 😁 We've had a chat and decided that we'd prefer not to include the enable/disable checkbox in the dialogs for now. Its worth noting that...

@dossantospat hopefully you didnt mean to close this?

![Logo](https://cdn.ast.checkmarx.net/integrations/logo/Checkmarx.png) **Checkmarx One – Scan Summary & Details** – [e95a4d44\-19a8\-4567\-9ab3\-e7b2e88bdc67](https://eu.ast.checkmarx.net/projects/0da811fa-6373-42b1-bbb6-d0026285b136/scans?id=e95a4d44-19a8-4567-9ab3-e7b2e88bdc67&branch=zapbot%2Fwebdriver-update) ### Great job, no security vulnerabilities found in this Pull Request

![Logo](https://cdn.ast.checkmarx.net/integrations/logo/Checkmarx.png) **Checkmarx One – Scan Summary & Details** – [7136a8b1\-645a\-43b8\-b127\-fa0574004ce7](https://eu.ast.checkmarx.net/projects/0da811fa-6373-42b1-bbb6-d0026285b136/scans?id=7136a8b1-645a-43b8-b127-fa0574004ce7&branch=kingthorin%2Fcp-moar) ### Great job\! No new security vulnerabilities introduced in this pull request

![Logo](https://cdn.ast.checkmarx.net/integrations/logo/Checkmarx.png) **Checkmarx One – Scan Summary & Details** – [872bcac0\-8b30\-474d\-b823\-2d6ff9d08ebb](https://eu.ast.checkmarx.net/projects/0da811fa-6373-42b1-bbb6-d0026285b136/scans?id=872bcac0-8b30-474d-b823-2d6ff9d08ebb&branch=AliceMilshtein%2FTOTP-feature) ### Great job, no security vulnerabilities found in this Pull Request

The build is failing due to formatting issues. Run `./gradlew :addOns:ascanrulesAlpha:spotlessApply` to fix these violations.

Just started playing with the examples in the dev add-on :) They are all under `/api/openapi` which is really for OpenAPI related content. I think they would make more sense...

I also noticed that in many (all) cases pressing RETURN did not submit the TOTP token. Was that deliberate? Most reasonable web apps I've used do accept RETURN as submit,...

@AliceMilshtein this PR still has conflicts