Pablo Saavedra Rodiño
Pablo Saavedra Rodiño
Fixed with https://github.com/Igalia/meta-webkit/pull/531
@aperezdc , I have a doubt for the GTK build: | -- No package 'sysprof-capture-4' found. Is sysprof really a mandatory depends? Can we set this depends off?
we are getting a build error for the WebKitGTK build: ``` 2024-09-19T10:40:08.8312493Z | /home/bot/yocto-webkit-scarthgap/builds/raspberrypi3-mesa-webkitgtk/tmp/work/cortexa7t2hf-neon-vfpv4-poky-linux-gnueabi/webkitgtk/2.46.0/build/bmalloc/Headers/bmalloc/EligibilityResult.h:35:5: error: expected identifier before numeric constant 2024-09-19T10:40:08.8314249Z | 35 | Success, 2024-09-19T10:40:08.8314565Z | | ^~~~~~~ 2024-09-19T10:40:08.8316408Z...
Likely the issue could be related with this flag: ``` //Whether to enable support for the X11 windowing target. ENABLE_X11_TARGET:BOOL=ON ```
> Likely the issue could be related with this flag: > > ``` > //Whether to enable support for the X11 windowing target. > ENABLE_X11_TARGET:BOOL=ON > ``` issue: https://bugs.webkit.org/show_bug.cgi?id=278858
> I still have a couple of comments. > > Also, the build is currently broken with `-DENABLE_VIDEO=OFF` (both in `main` and in the 2.46 release branch); there are patches...
Thanks @aperezdc I will take care of those patches and I will add it in a subsequent PR. 🙇🏼
Hi @Qingwu-Li, thank you for the PR. We really appreciate all contributions to the project. I have a few comments regarding the pull request: - `2.45.x` is not a stable...
> We are going to release 2.46.0 soon. It would be great if you could update this PR with an update to that version when it's available in some weeks....
> > We are going to release 2.46.0 soon. It would be great if you could update this PR with an update to that version when it's available in some...