meta-webkit icon indicating copy to clipboard operation
meta-webkit copied to clipboard

wpewebkit: Enable QtWPE build support for Qt6 for 2.46.0

Open Qingwu-Li opened this issue 1 year ago • 5 comments

Tested with QT6 build

know issue: gcc 11 may failed build neon.h failed for arm64, see https://github.com/Qingwu-Li/WebKit/commit/176cb80e1579308f5f4a534ee796b1a7855f6248

Qingwu-Li avatar Sep 06 '24 09:09 Qingwu-Li

@pabelenda Please do a review!

Qingwu-Li avatar Sep 06 '24 09:09 Qingwu-Li

Hi @Qingwu-Li, thank you for the PR. We really appreciate all contributions to the project. I have a few comments regarding the pull request:

  • 2.45.x is not a stable WPE release. Odd-numbered versions refer to development releases. I suggest adjusting the wpewebkit bump to version 2.44.4. Please note that this PR already handles the bump to 2.44.4.
  • Is Qt6 WPE not yet supported in 2.44? If that is the case, we could consider adding support for 2.45 as an exception, but with DEFAULT_PREFERENCE = "-1" in the recipe.

psaavedra avatar Sep 09 '24 14:09 psaavedra

  • Is Qt6 WPE not yet supported in 2.44? If that is the case, we could consider adding support for 2.45 as an exception, but with DEFAULT_PREFERENCE = "-1" in the recipe.

Hello @psaavedra , yes Qt6 WPE not supported in 2.44, Change in V2: Add DEFAULT_PREFERENCE = "-1" Fix the gcc 11(kirkstone) build simd failed issue.

Qingwu-Li avatar Sep 13 '24 06:09 Qingwu-Li

We are going to release 2.46.0 soon. It would be great if you could update this PR with an update to that version when it's available in some weeks.

aperezdc avatar Sep 13 '24 21:09 aperezdc

We are going to release 2.46.0 soon. It would be great if you could update this PR with an update to that version when it's available in some weeks.

This PR (https://github.com/Igalia/meta-webkit/pull/509) will move the WPE version to 2.46. I could be very happy to integrate your changes after this 509 is merged if you make the adaptations in this 506 PR.

psaavedra avatar Sep 18 '24 08:09 psaavedra

We are going to release 2.46.0 soon. It would be great if you could update this PR with an update to that version when it's available in some weeks.

This PR (#509) will move the WPE version to 2.46. I could be very happy to integrate your changes after this 509 is merged if you make the adaptations in this 506 PR.

#509 is ready and landed. Let's trigger the Actions for this PR.

psaavedra avatar Oct 15 '24 08:10 psaavedra

@Qingwu-Li is this PR still a Draft?

psaavedra avatar Oct 22 '24 07:10 psaavedra

modifed Upstream-Status to Upstream-Status: Submitted

Qingwu-Li avatar Oct 22 '24 09:10 Qingwu-Li