Christophe Prud'homme

Results 221 comments of Christophe Prud'homme

@thomas-saigre now it breaks later in the python part https://github.com/feelpp/feelpp/actions/runs/13460439204/job/37634551569#step:3:2691 it seems that you changed or renamed a parameter in the lib but not in the tests

@tldahlgren @jcortial-safran I believe I applied the required changes.

@wdconinc I hope that I fixed libzip, it should now follow the multi-build system rules

@bernhardkaindl all the variant are enabled by default by libzip so if they are not installed by spack, libzip will have a look on the host system and use that....

> > wdconinc I hope that I fixed libzip, it should now follow the multi-build system rules > > No, you just moved the variants into build_system=cmake. Wouter instead said...

@bernhardkaindl @wdconinc libzip was not properly defined and libzip picked up what was available from spack or the host. I believe to avoid creating too many issues all the default...

@bernhardkaindl thank you for the feedback and your patience. If I understand what you are saying it should be fine to get rid of autotools build_system because the versions associated...

@bernhardkaindl thank you for your very detailed work and review

@bernhardkaindl I think I followed your suggestions. - I removed the deprecated version and kept only the cmake based versions - I fixed the style Now libzip build by default...

@wdconinc I believe your suggestion has been taken care of.