spack icon indicating copy to clipboard operation
spack copied to clipboard

mmg : add variant to install private headers for parmmg packaged

Open prudhomm opened this issue 1 year ago • 4 comments

add private variant to install private headers thanks to MMG_INSTALL_PRIVATE_HEADERS needed by parmmg

/cc @jcortial-safran

  • closes feelpp/spack#14

prudhomm avatar Nov 03 '24 15:11 prudhomm

I would prefer a more explicit variant name, e.g. private_headers.

The variant should be also appear as a dependency in the parmmg package : https://github.com/spack/spack/blob/develop/var/spack/repos/builtin/packages/parmmg/package.py

jcortial-safran avatar Nov 04 '24 10:11 jcortial-safran

Unless I am mistaken the option is only available for version 5.7.0 or later : https://github.com/MmgTools/mmg/commit/9f98ef4050a59b56e651e1641e07b2b1253917c0

So the option should not be available for versions earlier than 5.7.0.

jcortial-safran avatar Nov 04 '24 15:11 jcortial-safran

LGTM. @jcortial-safran ?

I have suggested a couple of minor changes.

jcortial-safran avatar Nov 05 '24 08:11 jcortial-safran

Ping me with a comment here when this is ready to merge.

tldahlgren avatar Nov 12 '24 02:11 tldahlgren

@tldahlgren @jcortial-safran I believe I applied the required changes.

prudhomm avatar Dec 15 '24 20:12 prudhomm

LGTM @tldahlgren

jcortial-safran avatar Dec 18 '24 13:12 jcortial-safran