Prathmesh Prabhu comments

Results 26 comments of


                                            Prathmesh Prabhu

Require webpack 5 in our lib. Add minimum webpack and typescript versions to storybook. Update `html-to-parser` version

How do you feel about holding this PR back until we cut the next stable release branch. It's been a while since the last stable release, and it'd be good...

Require webpack 5 in our lib. Add minimum webpack and typescript versions to storybook. Update `html-to-parser` version

Feel free to merge this when ready. `1.4.0` release branch has been created: https://github.com/Azure/communication-ui-library/tree/release/1.4.0

Add TeamsCall and TeamsCallAgent to stateful

Actual PR review pending splitting off of the SDK version bump into its own PR.

GenerateSW has been called multiple times, perhaps due to running webpack in --watch mode.

This is a known issue that only affects local devserver runs. See https://github.com/GoogleChrome/workbox/issues/1790 for prior context.

Add TeamsCallAdapter interface

Please IM me when this is ready for another round of reviews. Would like to help get this over the finish line this week.

Add teams call into binding layer

Looks like this is ready for another round of review tomorrow morning?