communication-ui-library icon indicating copy to clipboard operation
communication-ui-library copied to clipboard

Require webpack 5 in our lib. Add minimum webpack and typescript versions to storybook. Update `html-to-parser` version

Open JamesBurnside opened this issue 1 year ago • 7 comments

What

  • Update html-to-parser version to the latest version that supports react 18
  • Add documentation for minimum typescript and webpack support
  • Update storybook manager to use webpack 5 (to avoid https://github.com/fb55/htmlparser2/issues/1237)
  • Update tools/check-treeshaking to use babel workaround for: https://github.com/fb55/htmlparser2/issues/1237

Why

Continuation of #2415 and #2427 to support react 18.

How Tested

Verified storybook ran locally.

JamesBurnside avatar Oct 21 '22 17:10 JamesBurnside

Storybook URL https://60c7ae6891f0e90039d7cd54-touvlhyebj.chromatic.com/

github-actions[bot] avatar Oct 21 '22 17:10 github-actions[bot]

CallWithChat bundle size is decreased✅.

  • Current size: 5652005
  • Base size: 5725729
  • Diff size: -73724

github-actions[bot] avatar Oct 21 '22 17:10 github-actions[bot]

Calling bundle size is decreased✅.

  • Current size: 5264705
  • Base size: 5338429
  • Diff size: -73724

github-actions[bot] avatar Oct 21 '22 17:10 github-actions[bot]

Chat bundle size is decreased✅.

  • Current size: 5385698
  • Base size: 5459488
  • Diff size: -73790

github-actions[bot] avatar Oct 21 '22 17:10 github-actions[bot]

How do you feel about holding this PR back until we cut the next stable release branch. It's been a while since the last stable release, and it'd be good to release this in a separate, smaller, stable release, clearly calling out the change.

prprabhu-ms avatar Oct 21 '22 18:10 prprabhu-ms

How do you feel about holding this PR back until we cut the next stable release branch. It's been a while since the last stable release, and it'd be good to release this in a separate, smaller, stable release, clearly calling out the change.

Sure thing!

JamesBurnside avatar Oct 21 '22 22:10 JamesBurnside

Storybook URL https://60c7ae6891f0e90039d7cd54-ohpcqxqqln.chromatic.com/

github-actions[bot] avatar Oct 21 '22 22:10 github-actions[bot]

Feel free to merge this when ready. 1.4.0 release branch has been created: https://github.com/Azure/communication-ui-library/tree/release/1.4.0

prprabhu-ms avatar Oct 24 '22 16:10 prprabhu-ms