Johan Euphrosine

consider adding SB_RGBA_DRV PWM verilog examples

4

It would be nice to show how to drive `RGB0PWM` `RGB1PWM` `RGB2PWM` using a clock divider, so achieve the same color cycling effect as the `risc-v` sample.

It would be nice if the `Hardware Description Languages` section mentioned simulating tooling like: - iverilog - gtkwave - verilator A few things that I wish I learned from the...

Document device actions sample support

1

This came up in #356 that device actions support in the sample is not very discoverable. We should consider: - [ ] move the [actions.json](https://github.com/googlesamples/assistant-sdk-python/blob/master/google-assistant-sdk/actions.json) in the `pushtotalk` directory -...

add third_party hotwording example

4

It would be nice to have an example showing integration between https://github.com/tensorflow/tensorflow/tree/master/tensorflow/lite/experimental/micro/examples/micro_speech and `google-assistant-grpc` This sample could show: - how to run the `micro_speech` in same process as the assistant...

provide event driven interface on top of google-assistant-grpc

9

As shown by the our documentation https://developers.google.com/assistant/sdk/guides/service/integrate#implement_a_basic_conversation_dialog_with_the_assistant and the rather complicated https://github.com/googlesamples/assistant-sdk-python/blob/84995692f35be8e085de8dfa7032039a13ae3fab/google-assistant-sdk/googlesamples/assistant/grpc/pushtotalk.py example, creating a functional assistant on top of the generated gRPC bindings is not trivial, it currently requires...

Audit reverse dependencies

1

As discussed in https://github.com/googlesamples/assistant-sdk-python/issues/358#issuecomment-552471651 it would be nice to audit project depending on `google-assistant-grpc` and `google-assistant-library`. For example: - https://github.com/search?q=%27google-assistant-grpc%27+filename%3Arequirements.txt&type=Code - https://github.com/search?q=%27google-assistant-library%27+filename%3Arequirements.txt&type=Code Additional processing could allow us to cluster those...

Now that we have https://github.com/googlesamples/assistant-sdk-python/blob/master/google-assistant-sdk/googlesamples/assistant/grpc/audiofileinput.py as a standalone sample, we could simply pushtotalk further by: - remove file input/output functionality - remove audio_helper and use https://python-sounddevice.readthedocs.io/ async API directly -...

It would be nice to show an example of registering/handling a custom device action for alarm, to bridge the functionality gap between the google-assistant-grpc and the deprecated google-assistant-library.

It would be nice to show an example of registering/handling https://developers.google.com/assistant/smarthome/traits/timer trait device action, to bridge the functionality gap between the `google-assistant-grpc` and the deprecated `google-assistant-library`.

The issue tracker in this repository is meant to track issue about the Google Assistant Service Python bindings and its associated samples. In order to avoid accumulating issue and feature...