Proddy

Results 624 comments of Proddy

I made some small changes to the branch to fix the UI settings. Your latest changes are good with memory without modbus code its 195 / 107 (free heap /...

Is there a way to add the Modbus registers dynamically as soon as they show up, like we do with MQTT Discovery?

Ok, I understand. I'll see if I can run the generation of `modbus_entity_parameters.hpp` as part of the platformio build target

I looked into automating this today, but it wouldn't compile. Seems running the generation of `src/modbus_entity_parameters.hpp` is not compatible with the modified class signatures. Can you take a look?

@mheyse any progress on this? It would be good to finally include it 3.7.0

Sorry to hear you were unwell. There's no rush - let me know how I can help

yes, I think it needs to be updated manually by running the script and the updated `modbus_entity_parameters.hpp` file checked in. Is there some documentation you like to write, which explains...

@mheyse I checked the code I think it's good to go. Can you refresh your local fork of the `dev` branch, then Git Merge your local copy of the `feat_modbus`...

Thanks for that - we'll review.