Proddy

Results 313 comments of Proddy

> I swithed to another action that does it easy. same here

I would welcome this feature too. The ability to add a body text (or filename) would be great. I've seen this in similar actions like https://github.com/ncipollo/release-action and https://github.com/softprops/action-gh-release. If I...

same here, I put all publishes in a queue (size 300 messages) and use a delay of 100ms. Works fine.

There is also https://github.com/yubox-node-org/AsyncTCPSock to consider, which is a re-write supporting TLS and backwards compatible. I haven't tried it yet but it's getting noticed in the AsyncWebServer world.

+1. I typically add const everywhere. And yes to using the uint8_t instead of char. Maybe worth running the code through cppcheck/clangtidy or a service like codacy to see what...

open question: how about natively supporting ArduinoJson as a payload type? Most of my publish payloads are JSON strings. They get serialized to a char * buffer and sent to...

yeah, you're right. probably not a good idea. In the code do you check for available heap before allowing it be stored in the temp buffer? I've seen someone implement...

ok, should have checked the code myself. nice work!