Proddy
Proddy
very clear, love the video! I'll take a look
that should work - thanks Michael for the fix. Verified with standalone too: `pio run -e standalone -t exec` and in console... ``` test add 0x18 157 call thermostat controlmode...
got any product ids? https://emsesp.github.io/docs/Troubleshooting/#not-all-ems-devices-are-recognized
could you go to the Telnet Console, `su` and then `read 38 2` and capture the response telegram. Do the same for 39. Let's see if the product ID is...
Adding this to 3.7.0 so we can look at it again. It may be resolved.
this is in test (called dev2). I'll keep it open until it's merged into dev
Hi @mheyse - I looked through the code the best I can and it looks solid. A few points: - Could we eventually wrap all the Modbus into `#define's` so...
This is going to be an awesome addition, nice work! - I suggest me, and Michael does a code review to familiarize ourselves with how it works and spot any...
I see the issue, the platformio `ci` target it misses setting the `build_flags` (this is a mistake!) which sets `-std=gnu++17`. `auto` lambdas are so more preferred over `std::function` if possible....
there's a typo at https://github.com/emsesp/EMS-ESP32/blob/14af4a0680ed015ea6f43d999aeaaa52c12e0780/platformio.ini#L46 with the extra "s" which is preventing the `lolin_s3` build from compiling. I'll fix in dev.