PyoungRyang Ko

Results 366 comments of PyoungRyang Ko

I am in favour of removing `insertKeepSize` and renaming `clipInsertKeepSize` to `clipInsert`. This pull request was created ten months ago, and I can no longer recall the exact reasoning behind...

With the following implementation: ``` ArrayedCollection : SequenceableCollection { ... clipInsert { arg index, item; var lastIndex = this.lastIndex; index = index.clip(0, lastIndex); ^this.insert(index, item)[0..lastIndex] } ... } ``` the...

@elgiano >shouldn't List.clipInsert return a new List? the current implementation returns an array and modifies the old list I would like to ensure I have correctly understood your review. **Step....

@elgiano I wanted to highlight an important aspect I considered when implementing this feature. ```supercollider a = [1, 2, 3] // -> [1, 2, 3] a.insert(0, 10) // -> [10,...

@elgiano I do not remember whether I thought the code structure you suggested. The following is the result of your implementation suggestion: ```supercollider l = List[1, 2, 3, 4, 5];...

Thank you for your valuable and kind opinions. I have conducted further testing and would like to provide a detailed report along with the reasoning behind my latest commit. ###...

Thank you very much for your comment and implementation suggestion! **Your implementation is indeed correct!** Here is how I have demonstrated that my approach was incorrect, and yours is correct:...

How about this change in https://github.com/supercollider/supercollider/pull/6394/commits/5e18589a240aa319f02e7744454cb8b2daf754e3?

> What happens when a user update there SC I install? The folders from the old SC version should be removed manually by the user.

>So their existing stuff won't work on a newly downloaded version - even minor build change. I'm not a fan of that. For each build, Quarks, Extension and all YALM...