Hiroki Osame

Results 652 comments of Hiroki Osame

Nitpicky but what do you think of `preserve_commit_history`?

I understand this change is not backwards compatible because of the case where users are using `personal_token` instead of `github_token` (so this is empty). AFAIK, using a PAT or GITHUB_TOKEN...

Gotcha, that makes sense. Updated the feature request to `external` instead of `linked`.

@joaomoreno If you're still blocked, fast ESM to AMD transformation may be a simple task on your end. You can use [`es-module-lexer`](https://github.com/guybedford/es-module-lexer) to reliably parse import/export statements. And then you...

Found that it fails on some `script` cases. For example: ```html Test export default { created() { const version = 1; this.versions = data.filter(v => version < v); }, };...

I can't tell how actively maintained this project is so I'm going to hold off until https://github.com/fkling/astexplorer/pull/515 and https://github.com/fkling/astexplorer/pull/514 are reviewed/merged before I spend more time on something that might...

Can you use: ```ts import type { NS } from "./types"; ```

I made a request here https://github.com/evanw/esbuild/issues/2390. But for reference, you can use `magic-string` to manipulate the source [like this](https://github.com/esbuild-kit/core-utils/blob/8a8a3d315cd2055fec92183e794b72df40c61892/src/transform/transform-dynamic-import.ts#L32-L42) and get a source map for the change. You can then...

esbuild doesn't support `linked` in the Transform API, but I think we can work around this by changing it to `eof` and extracting the comments out with [`magic-string`](https://github.com/Rich-Harris/magic-string) and emitting...