view_components

view_components copied to clipboard

[WIP] Support prop to announce banner when it is shown

2

This is a **proof of concep**t, and has a pre-req to ship: * https://github.com/primer/view_components/pull/2625 * `` should be part of the page layout of the consuming application. We probably want...

khiga8

upgrade @github/tab-container-element@latest

2

_Authors: Please fill out this form carefully and completely._ _Reviewers: By approving this Pull Request you are approving the code change, as well as its deployment and mitigation plans._ _Please...

keithamus

### Steps to reproduce 1. Go to https://view-components-storybook.eastus.cloudapp.azure.com/view-components/lookbook/inspect/primer/alpha/toggle_switch/small 2. Click on the toggle 3. Observe the position of the toggle ### Actual behaviour * The toggle jumps to the top...

HDinger

This is a recommendation that came out of [accessible banner exploration](https://github.com/github/accessibility/blob/main/docs/coaching-recommendations/toast-flash-banner/accessible-banner-prototype.md). Given that Banner is made visually prominent to sighted users through the use of icons and color, providing a...

khiga8

[Banner] Manage focus when PVC Banner is dismissed

1

### Context When the Banner component is dismissed, focus is lost. There has been a recent solution in the GitHub codebase to manage focus programmatically when a Banner is dismissed,...

lindseywild

Positioning and background of Dialog is wrong when opened without a trigger button

1

### Version 0.18.1 ### Steps to reroduce * Render a `Dialog` without calling `with_show_button` , e.g very simplified: ``` render(Primer::Alpha::Dialog.new(title: 'My awesome title', open: true)) do |d| d.with_body { 'Some...

HDinger

Overlay--size-auto to be width:fit-content

1

_Authors: Please fill out this form carefully and completely._ _Reviewers: By approving this Pull Request you are approving the code change, as well as its deployment and mitigation plans._ _Please...

keithamus

Update `custom_utilities` to include marketing utility classes

1

_Authors: Please fill out this form carefully and completely._ _Reviewers: By approving this Pull Request you are approving the code change, as well as its deployment and mitigation plans._ _Please...

francisfuzz

ActionList - allow sizing `with_avatar_item`

1

_Authors: Please fill out this form carefully and completely._ _Reviewers: By approving this Pull Request you are approving the code change, as well as its deployment and mitigation plans._ _Please...

bradshjg

Rewrite Dialog to use the Overlay component

4

The Dialog component does a lot of work that the Overlay component does. We should move styles and functionality to Overlay under the hood

jonrohan