view_components icon indicating copy to clipboard operation
view_components copied to clipboard

ActionList - allow sizing `with_avatar_item`

Open bradshjg opened this issue 1 year ago • 1 comments

Authors: Please fill out this form carefully and completely.

Reviewers: By approving this Pull Request you are approving the code change, as well as its deployment and mitigation plans. Please read this description carefully. If you feel there is anything unclear or missing, please ask for updates.

What are you trying to accomplish?

Currently the avatar size using with_avatar_item is hardcoded to 16px. The goal is to support a user-supplied value so that avatars in ActionLists can be sized.

Screenshots

TODO

Integration

TODO maybe it could be that folks are relying on a size key currently being ignored.

List the issues that this change affects.

TODO

Closes # (type the GitHub issue number after #)

Risk Assessment

  • [ ] Low risk the change is small, highly observable, and easily rolled back.
  • [ ] Medium risk changes that are isolated, reduced in scope or could impact few users. The change will not impact library availability.
  • [ ] High risk changes are those that could impact customers and SLOs, low or no test coverage, low observability, or slow to rollback.

What approach did you choose and why?

Anything you want to highlight for special attention from reviewers?

Accessibility

  • Fixes axe scan violation - This change fixes an existing axe scan violation.
  • No new axe scan violation - This change does not introduce any new axe scan violations.
  • New axe violation - This change introduces a new axe scan violation. Please describe why the violation cannot be resolved below.

Merge checklist

  • [ ] Added/updated tests
  • [ ] Added/updated documentation
  • [ ] Added/updated previews (Lookbook)
  • [ ] Tested in Chrome
  • [ ] Tested in Firefox
  • [ ] Tested in Safari
  • [ ] Tested in Edge

Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.

bradshjg avatar Jan 19 '24 22:01 bradshjg

⚠️ No Changeset found

Latest commit: 29964eb9df46c72a2ed87a27014ae2d25179590c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Jan 19 '24 22:01 changeset-bot[bot]

Hi! This pull request has been marked as stale because it has been open with no activity for 60 days. You can comment on the pull request or remove the stale label to keep it open. If you do nothing, this pull request will be closed in 7 days.

github-actions[bot] avatar Mar 19 '24 23:03 github-actions[bot]