Pratyaksh Sharma
Pratyaksh Sharma
@nsivabalan should be able to share the latest on this I believe.
@nsivabalan I am willing to take it up. I have already given it a shot in this PR. Let me know if you wish to discuss on slack or here...
@Akanksha-kedia There are 2 separate cherry-picks which serve different purposes, hence 2 different commits. I think verifications related to existing properties and what key value pairs are going to be...
This is ready for review now @yingsu00 @imjalpreet @agrawalreetika
After the recent push, build is failing. Working on this.
This is ready to be reviewed.
The test failures are related to the code changes from https://github.com/prestodb/presto/pull/21250. Once it gets merged into master, the failures should resolve
I see clickhouse tests are disabled in the pom.xml here - https://github.com/prestodb/presto/blob/7d1951652af763cfc0cb3421a66ff2b4f8df2d52/presto-clickhouse/pom.xml#L248. So should I still proceed with adding the clickhouse tests in this PR? @agrawalreetika @yingsu00 As per this...
I added the tests for clickhouse and have verified they are passing. However other existing tests are failing for clickhouse as reported in this issue - https://github.com/prestodb/presto/issues/21932. Hence I have...
@agrawalreetika @yingsu00 This is good to review now.