Prateek Maheshwari
Prateek Maheshwari
@pdu-mn1 Is this PR still relevant? If not, can you please close it? Thanks!
Thanks for the PR @georgantasp. @xinyuiscool Can you take a look at this?
@jmakes can we close this PR?
@rmatharu please use PR description format.
@shanthoosh FYI, is this PR still relevant?
You should use a gauge, not counter. In inGraphs, a counter is displayed as a rate (v2-v1/t2-t1). 1. That's probably not what you want. 2. Not sure what will happen...
@rmatharu Let's also add this to the metrics docs.
@rmatharu @bharathkk Please take a look.
@rmatharu @bharathkk This also fixes the issue where jobs want to write a rewriter to generate stores with side inputs, but the rewriter is currently run multiple times.
@mynameborat Good point, but we can fix that in the rewriter by making it aware of systems for side inputs (and probably for changelogs too). Would that work?